DATAMONGO-1054 - Add support for fast insertion via MongoRepository.insert(..). #253
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 28, 2014 15:47
…sses. Prepare issue branch.
…nsert(..). Introduced new insert(..) method variants on MongoRepositories that delegates to MongoTemplate.insert(..). This bypasses ID-population, save event generation and version checking and allows for fast insertion of bulk data. Original pull request: #253.
thomasdarimont
force-pushed
the
issue/DATAMONGO-1054
branch
from
d4488c2 to
714446b
Compare
…nsert(..). Guesstimate the proper capacity for the result lists.
thomasdarimont
pushed a commit
that referenced
this pull request
Nov 28, 2014
…nsert(..). Introduced new insert(..) method variants on MongoRepositories that delegates to MongoTemplate.insert(..). This bypasses ID-population, save event generation and version checking and allows for fast insertion of bulk data. Original pull request: #253.
odrotbohm
added a commit
that referenced
this pull request
Nov 28, 2014
Tweaked JavaDoc of the APIs to be less specific about implementation internals and rather point to the save(…) methods. Changed SimpleMongoRepository.save(…) methods to inspect the given entity/entities and use the optimized insert(All)-calls if all entities are considered new. Original pull request: #253.
thomasdarimont
pushed a commit
that referenced
this pull request
Nov 28, 2014
…nsert(..). Introduced new insert(..) method variants on MongoRepositories that delegates to MongoTemplate.insert(..). This bypasses ID-population, save event generation and version checking and allows for fast insertion of bulk data. Original pull request: #253.
odrotbohm
added a commit
that referenced
this pull request
Nov 28, 2014
Tweaked JavaDoc of the APIs to be less specific about implementation internals and rather point to the save(…) methods. Changed SimpleMongoRepository.save(…) methods to inspect the given entity/entities and use the optimized insert(All)-calls if all entities are considered new. Original pull request: #253.
|
Prior this change, when extending Thanks. |
|
Keep the |
|
Thanks @olivergierke I just figured moments after adding this comment that this would be the obvious solution. My bad. Thanks though. :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduced new insert(..) method variants on MongoRepositories that delegates to MongoTemplate.insert(..). This bypasses ID-population, save event generation and version checking and allows for fast insertion of bulk data.